Messages in this thread | | | Date | Sun, 27 Mar 2022 23:48:03 +0100 | From | Mark Brown <> | Subject | Re: [PATCH] regulator: wm8994: Add an off-on delay for WM8994 variant |
| |
On Sun, Mar 27, 2022 at 03:15:53PM -0700, Jonathan Bakker wrote:
> > + /* WM8994 requires an off-on delay while others do not */ > + if (ldo->wm8994->type == WM8994) > + wm8994_ldo_desc[id].off_on_delay = 36000;
You shouldn't modify the description - this wouldn't work in the unusual situation where there were one of these devices and is a bad pattern to set in case someone copies this to another device where it's more likely there could be multiple instances. It is much better to provide two descriptions and select the one which is needed at runtime. [unhandled content-type:application/pgp-signature] | |