Messages in this thread | | | From | Andy Shevchenko <> | Date | Sun, 27 Mar 2022 22:58:07 +0300 | Subject | Re: [PATCH v1 5/5] pinctrl: armada-37xx: Replace custom code by gpiochip_count() call |
| |
On Sat, Mar 26, 2022 at 7:02 PM Sergey Shtylyov <s.shtylyov@omp.ru> wrote: > On 3/25/22 11:03 PM, Andy Shevchenko wrote: > > > Since we have a generic function to count GPIO controller nodes > > under a given device, there is no need to open-code it. Replace > > custom code by gpiochip_count() call.
...
> > + nr_child_nodes = of_irq_count(np); > > Mhm, 'np' is no longer assigned to it at this point...
Good catch! We may retrieve it by calling
np = to_of_node(device_get_named_child_node(dev, "gpio-controller"));
like it's done in the previous patch in the series.
-- With Best Regards, Andy Shevchenko
| |