Messages in this thread | | | Date | Sun, 27 Mar 2022 21:45:11 +0200 | From | Sam Ravnborg <> | Subject | Re: [PATCH v5 3/3] drm/panel : innolux-ej030na and abt-y030xx067a : add .enable and .disable |
| |
Hi Christophe,
On Mon, Mar 21, 2022 at 03:42:08PM +0100, Christophe Branchereau wrote: > Sorry I meant "sleep out" not "sleep in" obviously > > On Mon, Mar 21, 2022 at 3:39 PM Christophe Branchereau > <cbranchereau@gmail.com> wrote: > > > > Following the introduction of bridge_atomic_enable in the ingenic > > drm driver, the crtc is enabled between .prepare and .enable, if > > it exists. Add it so the backlight is only enabled after the crtc is, to > > avoid graphical issues. > > > > As we're moving the "sleep in" command out of the init sequence > > into .enable for the ABT, we need to switch the regmap cache > > to REGCACHE_FLAT to be able to use regmap_set_bits, given this > > panel registers are write-ony and read as 0. > > > > On Mon, Mar 21, 2022 at 3:21 PM Paul Cercueil <paul@crapouillou.net> wrote: > > > > > > Hi Christophe, > > > > > > Le lun., mars 21 2022 at 14:36:51 +0100, Christophe Branchereau > > > <cbranchereau@gmail.com> a écrit : > > > > Following the introduction of bridge_atomic_enable in the ingenic > > > > drm driver, the crtc is enabled between .prepare and .enable, if > > > > it exists. > > > > > > > > Add it so the backlight is only enabled after the crtc is, to avoid > > > > graphical issues. > > > > > > > > Signed-off-by: Christophe Branchereau <cbranchereau@gmail.com> > > > > > > Didn't Sam acked it? No, that was the new driver, already replied.
For these changes - with the updated changelog: Acked-by: Sam Ravnborg <sam@ravnborg.org>
| |