lkml.org 
[lkml]   [2022]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] iio: adc: fix for_each_child.cocci warnings
On Sat, 26 Mar 2022 09:28:12 +0100 (CET)
Julia Lawall <julia.lawall@inria.fr> wrote:

> From: kernel test robot <lkp@intel.com>
>
> For_each_child_of_node should have of_node_put() before return.
>
> Generated by: scripts/coccinelle/iterators/for_each_child.cocci
>
> CC: Rajnikant Bhojani <rajnikant.bhojani@xilinx.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Julia Lawall <julia.lawall@inria.fr>

The upstream version (in IIO for now, but I'd imagine will hit Linus'
tree in next few days) of this looks rather different (no dt code an more)
so I suspect this fix is for a now dead branch...

Jonathan

> ---
>
> tree: https://github.com/Xilinx/linux-xlnx xlnx_rebase_v5.15_LTS
> head: 1870e0fa79a9d58c6748c34550f3ccea0b515933
> commit: d073b83d3f8f3ba83c59f7502371b1cf9eb35e92 [541/1029] iio: adc: Add Xilinx AMS driver
> :::::: branch date: 35 hours ago
> :::::: commit date: 8 weeks ago
>
> Please take the patch only if it's a positive warning. Thanks!
>
> drivers/iio/adc/xilinx-ams.c | 1 +
> 1 file changed, 1 insertion(+)
>
> --- a/drivers/iio/adc/xilinx-ams.c
> +++ b/drivers/iio/adc/xilinx-ams.c
> @@ -920,6 +920,7 @@ static int ams_parse_dt(struct iio_dev *
> ams_channels + num_channels);
> if (ret < 0) {
> kfree(ams_channels);
> + of_node_put(child_node);
> return ret;
> }
>

\
 
 \ /
  Last update: 2022-03-27 15:31    [W:0.066 / U:0.420 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site