lkml.org 
[lkml]   [2022]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 02/22] s3c: Replace comments with C99 initializers
From
Date
On Sat, 2022-03-26 at 17:58 +0100, Benjamin Stürz wrote:
> This replaces comments with C99's designated
> initializers because the kernel supports them now.
[]
> diff --git a/arch/arm/mach-s3c/bast-irq.c b/arch/arm/mach-s3c/bast-irq.c
[]
> @@ -29,22 +29,22 @@
> * the irq is not implemented
> */
> static const unsigned char bast_pc104_irqmasks[] = {
> - 0, /* 0 */
> - 0, /* 1 */
> - 0, /* 2 */
> - 1, /* 3 */
> - 0, /* 4 */
> - 2, /* 5 */
> - 0, /* 6 */
> - 4, /* 7 */
> - 0, /* 8 */
> - 0, /* 9 */
> - 8, /* 10 */
> - 0, /* 11 */
> - 0, /* 12 */
> - 0, /* 13 */
> - 0, /* 14 */
> - 0, /* 15 */
> + [0] = 0,
> + [1] = 0,
> + [2] = 0,
> + [3] = 1,
> + [4] = 0,
> + [5] = 2,
> + [6] = 0,
> + [7] = 4,
> + [8] = 0,
> + [9] = 0,
> + [10] = 8,
> + [11] = 0,
> + [12] = 0,
> + [13] = 0,
> + [14] = 0,
> + [15] = 0,
> };

I don't find this better than the initial array.

>
> static const unsigned char bast_pc104_irqs[] = { 3, 5, 7, 10 };

For the same reason this array is just an array
without the specified indexing.


\
 
 \ /
  Last update: 2022-03-26 20:46    [W:0.497 / U:0.556 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site