Messages in this thread | | | Date | Sat, 26 Mar 2022 13:49:56 +0800 | From | Leo Yan <> | Subject | Re: [PATCH v4 1/4] tools: arm64: Import cputype.h |
| |
Hi Arnaldo, Ali,
On Fri, Mar 25, 2022 at 04:42:32PM -0300, Arnaldo Carvalho de Melo wrote: > Em Fri, Mar 25, 2022 at 03:39:44PM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Thu, Mar 24, 2022 at 06:33:20PM +0000, Ali Saidi escreveu: > > > Bring-in the kernel's arch/arm64/include/asm/cputype.h into tools/ > > > for arm64 to make use of all the core-type definitions in perf. > > > > Replace sysreg.h with the version already imported into tools/. > > > You forgot to add it to tools/perf/check-headers.sh so that we get > > notificed when the original file in the kernel sources gets updated, so > > that we can check if this needs any tooling adjustments. > > > I'll add the entry together with the waiver for this specific > > difference. > > This: > > diff --git a/tools/perf/check-headers.sh b/tools/perf/check-headers.sh > index 30ecf3a0f68b6830..6ee44b18c6b57cf1 100755 > --- a/tools/perf/check-headers.sh > +++ b/tools/perf/check-headers.sh > @@ -146,6 +146,7 @@ done > check arch/x86/lib/memcpy_64.S '-I "^EXPORT_SYMBOL" -I "^#include <asm/export.h>" -I"^SYM_FUNC_START\(_LOCAL\)*(memcpy_\(erms\|orig\))"' > check arch/x86/lib/memset_64.S '-I "^EXPORT_SYMBOL" -I "^#include <asm/export.h>" -I"^SYM_FUNC_START\(_LOCAL\)*(memset_\(erms\|orig\))"' > check arch/x86/include/asm/amd-ibs.h '-I "^#include [<\"]\(asm/\)*msr-index.h"' > +check arch/arm64/include/asm/cputype.h '-I "^#include [<\"]\(asm/\)*sysreg.h"' > check include/uapi/asm-generic/mman.h '-I "^#include <\(uapi/\)*asm-generic/mman-common\(-tools\)*.h>"' > check include/uapi/linux/mman.h '-I "^#include <\(uapi/\)*asm/mman.h>"' > check include/linux/build_bug.h '-I "^#\(ifndef\|endif\)\( \/\/\)* static_assert$"'
LGTM. I did the testing on both my x86 and Arm64 platforms, thanks for the fixing up.
Thanks, Leo
| |