lkml.org 
[lkml]   [2022]   [Mar]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2 1/2] dt-bindings: soc: bcm: bcm2835-vchiq: Add support for bcm2711
From
On 24/03/2022 19:47, Krzysztof Kozlowski wrote:
> On 24/03/2022 18:26, Adrien Thierry wrote:
>> Add a new compatible string for BCM2711. This is the chip used on the
>> Raspberry Pi 4.
>>
>> Signed-off-by: Adrien Thierry <athierry@redhat.com>
>> ---
>> Changes since v1:
>> - Removed duplicate compatible string for bcm2711
>>
>> .../devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml b/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml
>> index e04439b3355b..9cb957facae0 100644
>> --- a/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml
>> +++ b/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml
>> @@ -27,6 +27,11 @@ properties:
>> - brcm,bcm2836-vchiq
>> - const: brcm,bcm2835-vchiq
>>
>> + - description: BCM2711 based boards
>> + items:
>> + - enum:
>> + - brcm,bcm2711-vchiq
>
> This oneOf here - just to add description which is copy-paste of
> compatible - does not make sense. It should be just enum with
> compatibles. At least for 2711 and 2835 (and put them in alphabetical
> order).

Actually, judging by your driver and DTS, it seems that this should be
list of items bcm2711 followed by bcm2836.


Best regards,
Krzysztof

\
 
 \ /
  Last update: 2022-03-25 08:17    [W:1.650 / U:0.448 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site