Messages in this thread | | | From | Pkshih <> | Subject | RE: [PATCH] rtlwifi: replace usage of found with dedicated list iterator variable | Date | Fri, 25 Mar 2022 07:11:01 +0000 |
| |
> -----Original Message----- > From: Jakob Koschel <jakobkoschel@gmail.com> > Sent: Thursday, March 24, 2022 3:21 PM > To: Pkshih <pkshih@realtek.com> > Cc: Kalle Valo <kvalo@kernel.org>; David S. Miller <davem@davemloft.net>; Jakub Kicinski <kuba@kernel.org>; > Paolo Abeni <pabeni@redhat.com>; linux-wireless@vger.kernel.org; netdev@vger.kernel.org; > linux-kernel@vger.kernel.org; Mike Rapoport <rppt@kernel.org>; Brian Johannesmeyer > <bjohannesmeyer@gmail.com>; Cristiano Giuffrida <c.giuffrida@vu.nl>; Bos, H.J. <h.j.bos@vu.nl>; Jakob > Koschel <jakobkoschel@gmail.com> > Subject: [PATCH] rtlwifi: replace usage of found with dedicated list iterator variable > > To move the list iterator variable into the list_for_each_entry_*() > macro in the future it should be avoided to use the list iterator > variable after the loop body. > > To *never* use the list iterator variable after the loop it was > concluded to use a separate iterator variable instead of a > found boolean [1]. > > This removes the need to use a found variable and simply checking if > the variable was set, can determine if the break/goto was hit. > > Link: https://lore.kernel.org/all/CAHk-=wgRr_D8CB-D9Kg-c=EHreAsk5SqXPwr9Y7k9sA6cWXJ6w@mail.gmail.com/ > Signed-off-by: Jakob Koschel <jakobkoschel@gmail.com>
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
Thanks.
[...]
| |