Messages in this thread | | | Date | Fri, 25 Mar 2022 16:10:52 +0100 | From | Clément Léger <> | Subject | Re: [PATCH v3 4/9] device property: add fwnode_property_read_string_index() |
| |
Le Fri, 25 Mar 2022 16:33:54 +0200, Andy Shevchenko <andriy.shevchenko@linux.intel.com> a écrit :
> On Fri, Mar 25, 2022 at 12:31:43PM +0100, Clément Léger wrote: > > Add fwnode_property_read_string_index() function which allows to > > retrieve a single string from an array by its index. This function is > > the equivalent of of_property_read_string_index() but for fwnode > > support. > > ... > > > + ret = fwnode_call_int_op(fwnode, property_read_string_array, propname, > > + string, 1, index); > > + if (ret == -EINVAL && !IS_ERR_OR_NULL(fwnode) && > > + !IS_ERR_OR_NULL(fwnode->secondary)) > > + ret = fwnode_call_int_op(fwnode->secondary, > > + property_read_string_array, propname, > > + string, 1, index); > > This is not fully correct. See [1] for the details. > I hope to send the new version just after the merge window ends. > > [1]: https://lore.kernel.org/lkml/20220308123712.18613-1-andriy.shevchenko@linux.intel.com/ >
Ok, I think we can wait for your patch to be applied in that case.
-- Clément Léger, Embedded Linux and Kernel engineer at Bootlin https://bootlin.com
| |