lkml.org 
[lkml]   [2022]   [Mar]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 18/20] crypto: qat - disable registration of algorithms
    Date
    From: Giovanni Cabiddu <giovanni.cabiddu@intel.com>

    commit 8893d27ffcaf6ec6267038a177cb87bcde4dd3de upstream.

    The implementations of aead and skcipher in the QAT driver do not
    support properly requests with the CRYPTO_TFM_REQ_MAY_BACKLOG flag set.
    If the HW queue is full, the driver returns -EBUSY but does not enqueue
    the request.
    This can result in applications like dm-crypt waiting indefinitely for a
    completion of a request that was never submitted to the hardware.

    To avoid this problem, disable the registration of all crypto algorithms
    in the QAT driver by setting the number of crypto instances to 0 at
    configuration time.

    Cc: stable@vger.kernel.org
    Signed-off-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
    Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/crypto/qat/qat_common/qat_crypto.c | 8 ++++++++
    1 file changed, 8 insertions(+)

    --- a/drivers/crypto/qat/qat_common/qat_crypto.c
    +++ b/drivers/crypto/qat/qat_common/qat_crypto.c
    @@ -170,6 +170,14 @@ int qat_crypto_dev_config(struct adf_acc
    goto err;
    if (adf_cfg_section_add(accel_dev, "Accelerator0"))
    goto err;
    +
    + /* Temporarily set the number of crypto instances to zero to avoid
    + * registering the crypto algorithms.
    + * This will be removed when the algorithms will support the
    + * CRYPTO_TFM_REQ_MAY_BACKLOG flag
    + */
    + instances = 0;
    +
    for (i = 0; i < instances; i++) {
    val = i;
    snprintf(key, sizeof(key), ADF_CY "%d" ADF_RING_BANK_NUM, i);

    \
     
     \ /
      Last update: 2022-03-25 16:09    [W:2.526 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site