Messages in this thread | | | Date | Fri, 25 Mar 2022 12:02:09 +0100 | From | Cyril Hrubis <> | Subject | Re: [RFC PATCH] getvalues(2) prototype |
| |
Hi! > > If so, have you benchmarked lsof using this new interface? > > Not yet. Looked yesterday at both lsof and procps source code, and > both are pretty complex and not easy to plug in a new interface. But > I've not yet given up...
Looking at lsof it seems to use fopen() and fgets() to parse various proc files. I doubt that we can make the parsing singificantly faster without completely rewriting the internals.
As for procps the readproc.c has file2str() function that does copy whole proc files into a buffer with open() - read() - close(). It may be reasonably easy to hook the new systall there and it will probably make ps and top slightly faster.
-- Cyril Hrubis chrubis@suse.cz
| |