lkml.org 
[lkml]   [2022]   [Mar]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v1] soc: bcm: Check for NULL return of devm_kzalloc()
From
Date
Hello!

s/return/result/ in the subject.

On 3/24/22 11:35 AM, QintaoShen wrote:

> As the potential failuer of allocation, devm_kzalloc() may return NULL.
> Then the 'pd->pmb' and the follow lines of code may bring null pointer dereference.

Following.

> Therefore, it is better to check the return value of devm_kzalloc() to avoid this confusion.
>
> Signed-off-by: QintaoShen <unSimple1993@163.com>
> ---
> drivers/soc/bcm/bcm63xx/bcm-pmb.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/soc/bcm/bcm63xx/bcm-pmb.c b/drivers/soc/bcm/bcm63xx/bcm-pmb.c
> index 7bbe46e..55bf389 100644
> --- a/drivers/soc/bcm/bcm63xx/bcm-pmb.c
> +++ b/drivers/soc/bcm/bcm63xx/bcm-pmb.c
> @@ -311,6 +311,8 @@ static int bcm_pmb_probe(struct platform_device *pdev)
>
> for (e = table; e->name; e++) {
> struct bcm_pmb_pm_domain *pd = devm_kzalloc(dev, sizeof(*pd), GFP_KERNEL);

Please keep an empty line after declaration.

> + if (!pd)
> + return -ENOMEM;
>
> pd->pmb = pmb;
> pd->data = e;

MBR, Sergey

\
 
 \ /
  Last update: 2022-03-25 10:03    [W:0.081 / U:0.588 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site