Messages in this thread | | | From | Diego Viola <> | Date | Wed, 23 Mar 2022 04:24:16 -0300 | Subject | Re: [PATCH] ata: libata-core: fix "it's" typos |
| |
On Wed, Mar 23, 2022 at 2:53 AM Damien Le Moal <damien.lemoal@opensource.wdc.com> wrote: > > On 3/23/22 14:52, Diego Viola wrote: > > On Wed, Mar 23, 2022 at 2:45 AM Damien Le Moal > > <damien.lemoal@opensource.wdc.com> wrote: > >> > >> On 3/23/22 14:40, Diego Viola wrote: > >>> Use the contraction "it's" instead of the possessive form "its". > >> > >> Well, while at it, let's use proper formal written English, so: > >> s/it's/it is > >> s/isn't/is not > > > > Fine with me, do you want me to send you another patch with those changes? > > Yes please.
I sent a v2 patch changing those things you pointed out, however, the whole comment[0] looks informal "But wait.. there's more" and I don't think replacing "it's" with "it is" achieves a lot in this case.
[0] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/ata/libata-core.c#n1399
Diego
| |