Messages in this thread | | | Date | Wed, 23 Mar 2022 23:35:11 +0300 | Subject | Re: [PATCH v3] can: mcba_usb: properly check endpoint type | From | Pavel Skripkin <> |
| |
On 3/13/22 13:09, Pavel Skripkin wrote: > Syzbot reported warning in usb_submit_urb() which is caused by wrong > endpoint type. We should check that in endpoint is actually present to > prevent this warning > > Found pipes are now saved to struct mcba_priv and code uses them directly > instead of making pipes in place. > > Fail log: > > usb 5-1: BOGUS urb xfer, pipe 3 != type 1 > WARNING: CPU: 1 PID: 49 at drivers/usb/core/urb.c:502 usb_submit_urb+0xed2/0x18a0 drivers/usb/core/urb.c:502 > Modules linked in: > CPU: 1 PID: 49 Comm: kworker/1:2 Not tainted 5.17.0-rc6-syzkaller-00184-g38f80f42147f #0 > Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.14.0-2 04/01/2014 > Workqueue: usb_hub_wq hub_event > RIP: 0010:usb_submit_urb+0xed2/0x18a0 drivers/usb/core/urb.c:502 > ... > Call Trace: > <TASK> > mcba_usb_start drivers/net/can/usb/mcba_usb.c:662 [inline] > mcba_usb_probe+0x8a3/0xc50 drivers/net/can/usb/mcba_usb.c:858 > usb_probe_interface+0x315/0x7f0 drivers/usb/core/driver.c:396 > call_driver_probe drivers/base/dd.c:517 [inline] > > Reported-and-tested-by: syzbot+3bc1dce0cc0052d60fde@syzkaller.appspotmail.com > Fixes: 51f3baad7de9 ("can: mcba_usb: Add support for Microchip CAN BUS Analyzer") > Signed-off-by: Pavel Skripkin <paskripkin@gmail.com> > Reviewed-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
gentle ping. looks like this patch got somehow lost
With regards, Pavel Skripkin [unhandled content-type:application/pgp-signature] | |