Messages in this thread | | | Date | Wed, 23 Mar 2022 15:13:04 -0500 | From | Rob Herring <> | Subject | Re: [PATCH 3/3] spi: dt-bindings: Add wait state polling flag |
| |
On Thu, Mar 17, 2022 at 06:50:06AM +0530, Krishna Yarlagadda wrote: > Add flag to enable tpm wait state polling and Tegra Grace binding.
TPM
> > Signed-off-by: Krishna Yarlagadda <kyarlagadda@nvidia.com> > --- > .../devicetree/bindings/spi/nvidia,tegra210-quad.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/spi/nvidia,tegra210-quad.yaml b/Documentation/devicetree/bindings/spi/nvidia,tegra210-quad.yaml > index 0296edd1de22..88b00fcad210 100644 > --- a/Documentation/devicetree/bindings/spi/nvidia,tegra210-quad.yaml > +++ b/Documentation/devicetree/bindings/spi/nvidia,tegra210-quad.yaml > @@ -20,6 +20,7 @@ properties: > - nvidia,tegra186-qspi > - nvidia,tegra194-qspi > - nvidia,tegra234-qspi > + - nvidia,tegra-grace-qspi > > reg: > maxItems: 1 > @@ -57,6 +58,11 @@ patternProperties: > spi-tx-bus-width: > enum: [1, 2, 4] > > + nvidia,wait-polling: > + description: > + Enable TPM wait state polling on supported chips.
What's TPM?
Why is this not implied by the compatible string?
Also, how child node properties are handled has changed. See Documentation/devicetree/bindings/spi/spi-peripheral-props.yaml. The NVidia specific properties should be refactored first before adding more.
> + type: boolean > + > nvidia,tx-clk-tap-delay: > description: > Delays the clock going out to device with this tap value. > -- > 2.17.1 > >
| |