Messages in this thread | | | Date | Wed, 23 Mar 2022 19:02:47 +0100 (CET) | From | Miroslav Benes <> | Subject | Re: [RFC PATCH 1/3] objtool: Move common code to utils.c |
| |
> +#define sym_for_each_insn(file, sym, insn) \ > + for (insn = find_insn(file, sym->sec, sym->offset); \ > + insn && &insn->list != &file->insn_list && \ > + insn->sec == sym->sec && \ > + insn->offset < sym->offset + sym->len; \ > + insn = list_next_entry(insn, list)) > + > +#endif /* UTILS_H */
Since you include <objtool/utils.h> in check.c, you can remove the definition of sym_for_each_insn() macro from check.c as well.
I wonder if it would make sense to move all these helper functions to utils.c and utils.h. Might be connected to what Josh wrote about his work on objtool interface.
Regards Miroslav
| |