Messages in this thread | | | From | Rob Herring <> | Date | Wed, 23 Mar 2022 09:05:32 -0500 | Subject | Re: [PATCH] dt-bindings: media: mediatek,vcodec: Fix addressing cell sizes |
| |
On Tue, Mar 1, 2022 at 5:35 PM Rob Herring <robh@kernel.org> wrote: > > 'dma-ranges' in the example is written for cell sizes of 2 cells, but > the schema and example specify sizes of 1 cell. As the h/w has a bus > address of >32-bits, cell sizes of 2 is correct. Update the schema's > '#address-cells' and '#size-cells' to be 2 and adjust the example > throughout. > > There's no error currently because dtc only checks 'dma-ranges' is a > correct multiple number of cells (3) and the schema checking is based on > bracketing of entries. > > Signed-off-by: Rob Herring <robh@kernel.org> > --- > I noticed the driver is checking 'dma-ranges' itself. That's generally > wrong as the core code should be configuring bus dma masks > automatically. > --- > .../media/mediatek,vcodec-subdev-decoder.yaml | 122 +++++++++--------- > 1 file changed, 64 insertions(+), 58 deletions(-)
Can this fix be applied for rc1? Still failing in linux-next.
Rob
| |