lkml.org 
[lkml]   [2022]   [Mar]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 5/9] soc: apple: Add RTKit IPC library
From
On 21/03/2022 17:50, Sven Peter wrote:
> Apple SoCs such as the M1 come with multiple embedded co-processors
> running proprietary firmware. Communication with those is established
> over a simple mailbox using the RTKit IPC protocol.
>
> Signed-off-by: Sven Peter <sven@svenpeter.dev>
> ---
> drivers/soc/apple/Kconfig | 13 +
> drivers/soc/apple/Makefile | 3 +
> drivers/soc/apple/rtkit-crashlog.c | 147 +++++
> drivers/soc/apple/rtkit-internal.h | 76 +++
> drivers/soc/apple/rtkit.c | 842 +++++++++++++++++++++++++++++
> include/linux/soc/apple/rtkit.h | 203 +++++++
> 6 files changed, 1284 insertions(+)

Isn't this some implementation of a mailbox? If so, it should be in
drivers/mailbox. Please don't put all stuff in soc/apple, that's not how
Linux is organized. To drivers/soc usually we put drivers which do not
fit regular subsystems.

Best regards,
Krzysztof

\
 
 \ /
  Last update: 2022-03-23 12:21    [W:0.247 / U:3.484 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site