Messages in this thread | | | Date | Wed, 23 Mar 2022 09:58:00 +0200 | Subject | Re: [PATCH v3] perf intel-pt: Synthesize cycle events | From | Adrian Hunter <> |
| |
On 22/03/2022 23:53, Steinar H. Gunderson wrote: > On Tue, Mar 22, 2022 at 06:32:18PM -0300, Arnaldo Carvalho de Melo wrote: >> I saw there was some issue, should I proceed and apply this v3 patch or >> wait for some v4? > > There are two issues in play: > > 1. PT event synth doesn't support reading inline information from DWARF > yet, and my patch to add it runs into some problems. This is not > relevant for this patch at all. > 2. The results from v3 don't quite match the ones from v1, and neither > of us are entirely sure why. My personal feeling is that the one > from v1 are the wrong ones, but it's up to Adrian to say whether we > want to try to investigate deeply here.
V3 is good. Please take that.
| |