lkml.org 
[lkml]   [2022]   [Mar]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/7] ARM: dts: s5pv210: Adjust I2S entries to match spec
On 23/03/2022 16:03, Jonathan Bakker wrote:
> Based on the device tree spec, clocks should be ordered tx/rx.
> Re-order from rx/tx to avoid warnings when running make dtbs_check
>
> Additionally, the number of #sound-dai-cells should be 1, not 0
>
> Signed-off-by: Jonathan Bakker <xc-racer2@live.ca>
> ---
> arch/arm/boot/dts/s5pv210-aries.dtsi | 2 +-
> arch/arm/boot/dts/s5pv210.dtsi | 18 +++++++++---------
> 2 files changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/arch/arm/boot/dts/s5pv210-aries.dtsi b/arch/arm/boot/dts/s5pv210-aries.dtsi
> index 70ff56daf4cb..503b5a50ef1a 100644
> --- a/arch/arm/boot/dts/s5pv210-aries.dtsi
> +++ b/arch/arm/boot/dts/s5pv210-aries.dtsi
> @@ -644,7 +644,7 @@
> };
>
> &i2s0 {
> - dmas = <&pdma0 9>, <&pdma0 10>, <&pdma0 11>;
> + dmas = <&pdma0 10>, <&pdma0 9>, <&pdma0 11>;
> status = "okay";

Except that fix that's the same commit as here:
https://lore.kernel.org/all/20200907161141.31034-26-krzk@kernel.org/
so just extend it.

sound-dai-cells should go to a separate commit. But are you sure they
are correct? The Fascinate 4G seems to be using them as cells=0.


Best regards,
Krzysztof

\
 
 \ /
  Last update: 2022-09-17 16:18    [W:0.136 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site