Messages in this thread | | | Date | Tue, 22 Mar 2022 17:53:55 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH] perf parse-events: Move slots only with topdown |
| |
Em Tue, Mar 22, 2022 at 07:48:48AM -0400, Liang, Kan escreveu: > On 3/21/2022 6:33 PM, Ian Rogers wrote: > > If slots isn't with a topdown event then moving it is unnecessary. For > > example {instructions, slots} is re-ordered: > > > > $ perf stat -e '{instructions,slots}' -a sleep 1 > > > > Performance counter stats for 'system wide': > > > > 936,600,825 slots > > 144,440,968 instructions > > > > 1.006061423 seconds time elapsed > > > > Which can break tools expecting the command line order to match the > > printed order. It is necessary to move the slots event first when it > > appears with topdown events. Add extra checking so that the slots event > > is only moved in the case of there being a topdown event like: > > > > $ perf stat -e '{instructions,slots,topdown-fe-bound}' -a sleep 1 > > > > Performance counter stats for 'system wide': > > > > 2427568570 slots > > 300927614 instructions > > 551021649 topdown-fe-bound > > > > 1.001771803 seconds time elapsed > > > > Fixes: 94dbfd6781a0 ("perf parse-events: Architecture specific leader override") > > Reported-by: Kan Liang <kan.liang@linux.intel.com> > > Signed-off-by: Ian Rogers <irogers@google.com> > > Thanks Ian. The patch works well. > > Tested-by: Kan Liang <kan.liang@linux.intel.com>
Thanks, applied.
- Arnaldo
| |