lkml.org 
[lkml]   [2022]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] perf parse-events: Move slots only with topdown
Em Tue, Mar 22, 2022 at 07:48:48AM -0400, Liang, Kan escreveu:
> On 3/21/2022 6:33 PM, Ian Rogers wrote:
> > If slots isn't with a topdown event then moving it is unnecessary. For
> > example {instructions, slots} is re-ordered:
> >
> > $ perf stat -e '{instructions,slots}' -a sleep 1
> >
> > Performance counter stats for 'system wide':
> >
> > 936,600,825 slots
> > 144,440,968 instructions
> >
> > 1.006061423 seconds time elapsed
> >
> > Which can break tools expecting the command line order to match the
> > printed order. It is necessary to move the slots event first when it
> > appears with topdown events. Add extra checking so that the slots event
> > is only moved in the case of there being a topdown event like:
> >
> > $ perf stat -e '{instructions,slots,topdown-fe-bound}' -a sleep 1
> >
> > Performance counter stats for 'system wide':
> >
> > 2427568570 slots
> > 300927614 instructions
> > 551021649 topdown-fe-bound
> >
> > 1.001771803 seconds time elapsed
> >
> > Fixes: 94dbfd6781a0 ("perf parse-events: Architecture specific leader override")
> > Reported-by: Kan Liang <kan.liang@linux.intel.com>
> > Signed-off-by: Ian Rogers <irogers@google.com>
>
> Thanks Ian. The patch works well.
>
> Tested-by: Kan Liang <kan.liang@linux.intel.com>

Thanks, applied.

- Arnaldo

\
 
 \ /
  Last update: 2022-03-22 21:55    [W:0.046 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site