lkml.org 
[lkml]   [2022]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] gpio: Drop CONFIG_DEBUG_GPIO
On Tue, Mar 22, 2022 at 3:38 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> On Fri, Mar 11, 2022 at 4:55 AM Brian Norris <briannorris@chromium.org> wrote:
>
> ...
>
> > Description: it says nothing about enabling extra printk()s. But -DDEBUG
> > does just that; it turns on every dev_dbg()/pr_debug() that would
> > otherwise be silent.
>
> Which is what some and I are using a lot during development.
>

AFAIK this: https://www.kernel.org/doc/local/pr_debug.txt is the right
way to do it?

https://www.kernel.org/doc/local/pr_debug.txt

This doesn't mention adding Kconfig options just to enable debug messages.

> ...
>
> > -ccflags-$(CONFIG_DEBUG_GPIO) += -DDEBUG
> > -
>
> NAK to this change.
>
> I'm not against enabling might_sleep() unconditionally.
>

These are already controlled by CONFIG_DEBUG_ATOMIC_SLEEP, no? Or
maybe I can't parse that double negation.

Bart

\
 
 \ /
  Last update: 2022-03-22 15:50    [W:0.288 / U:0.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site