Messages in this thread Patch in this message | | | From | Jeff Layton <> | Subject | [RFC PATCH v11 01/51] vfs: export new_inode_pseudo | Date | Tue, 22 Mar 2022 10:12:26 -0400 |
| |
Ceph needs to be able to allocate inodes ahead of a create that might involve a fscrypt-encrypted inode. new_inode() almost fits the bill, but it puts the inode on the sb->s_inodes list and when we go to hash it, that might be done again.
We could work around that by setting I_CREATING on the new inode, but that causes ilookup5 to return -ESTALE if something tries to find it before I_NEW is cleared. This is desirable behavior for most filesystems, but doesn't work for ceph.
To work around all of this, just use new_inode_pseudo which doesn't add it to the sb->s_inodes list.
Cc: Al Viro <viro@zeniv.linux.org.uk> Signed-off-by: Jeff Layton <jlayton@kernel.org> --- fs/inode.c | 1 + 1 file changed, 1 insertion(+)
Al, can I get your Acked-by on this if you're OK with it? Alternately if you just want to take it in via your tree, then that would be fine too.
diff --git a/fs/inode.c b/fs/inode.c index 63324df6fa27..9ddf7d1a7359 100644 --- a/fs/inode.c +++ b/fs/inode.c @@ -1025,6 +1025,7 @@ struct inode *new_inode_pseudo(struct super_block *sb) } return inode; } +EXPORT_SYMBOL(new_inode_pseudo); /** * new_inode - obtain an inode -- 2.35.1
| |