Messages in this thread | | | Subject | Re: [PATCH v2 1/1] perf test arm64: Test unwinding using fame-pointer (fp) mode | From | German Gomez <> | Date | Tue, 22 Mar 2022 13:27:52 +0000 |
| |
On 21/03/2022 20:52, Arnaldo Carvalho de Melo wrote: > Em Wed, Mar 16, 2022 at 05:48:50PM +0000, German Gomez escreveu: >> On 16/03/2022 17:30, James Clark wrote: >>> On 16/03/2022 17:20, German Gomez wrote: >>>> Add a shell script to check that the call-graphs generated using frame >>>> pointers (--call-graph fp) are complete and not missing leaf functions: >>>> >>>> | $ perf test 88 -v >>>> | 88: Check Arm64 callgraphs are complete in fp mode : >>>> | --- start --- >>>> | test child forked, pid 8734 >>>> | + Compiling test program (/tmp/test_program.Cz3yL)... >>>> | + Recording (PID=8749)... >>>> | + Stopping perf-record... >>>> | test_program.Cz >>>> | 728 leaf >>>> | 753 parent >>>> | 76c main >>>> | test child finished with 0 >>>> | ---- end ---- >>>> | Check Arm SPE callgraphs are complete in fp mode: Ok >>>> >>> Ran it on N1SDP and it passes, and it fails if b9f6fbb3b2c2 isn't applied. >> I forgot to mention in the notes that it's supposed to work with both unwinders: >> >> $ make # for libunwind (default) >> $ make NO_LIBUNWIND=1 # for libdw > I'll add it to the cset commit log, and also will fix this: > > ⬢[acme@toolbox perf]$ git am ./v2_20220316_german_gomez_perf_test_arm64_test_unwinding_using_fame_pointer_fp_mode.mbx > Applying: perf test arm64: Test unwinding using fame-pointer (fp) mode > .git/rebase-apply/patch:72: trailing whitespace. > # program > warning: 1 line adds whitespace errors. > tools/perf/tests/shell/test_arm_callgraph_fp.sh:58: trailing whitespace. > +# program > ⬢[acme@toolbox perf]$ >
Thanks Arnaldo, I forgot to run the checkpatch script.
>>> Reviewed-by: James Clark <james.clark@arm.com> >>> >>>> Fixes: b9f6fbb3b2c2 ("perf arm64: Inject missing frames when using 'perf record --call-graph=fp'") >>>> Suggested-by: Jiri Olsa <jolsa@kernel.org> >>>> Signed-off-by: German Gomez <german.gomez@arm.com>
| |