lkml.org 
[lkml]   [2022]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v18 14/18] s390/vfio-ap: sysfs attribute to display the guest's matrix
From
On 2/14/22 19:50, Tony Krowiak wrote:
> The matrix of adapters and domains configured in a guest's APCB may
> differ from the matrix of adapters and domains assigned to the matrix mdev,
> so this patch introduces a sysfs attribute to display the matrix of
> adapters and domains that are or will be assigned to the APCB of a guest
> that is or will be using the matrix mdev. For a matrix mdev denoted by
> $uuid, the guest matrix can be displayed as follows:
>
> cat /sys/devices/vfio_ap/matrix/$uuid/guest_matrix
My OCD wants you to name this matrix_guest instead of guest_matrix. Simply
because then "matrix" and "matrix_guest" will be grouped together when doing
an ls on the parent directory. As a system admin, its the little things that
make the difference :) Please consider... though I won't withhold an R-b for
it.

Reviewed-by: Jason J. Herne <jjherne@linux.ibm.com>

--
-- Jason J. Herne (jjherne@linux.ibm.com)

\
 
 \ /
  Last update: 2022-03-22 14:23    [W:0.390 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site