Messages in this thread | | | Date | Tue, 22 Mar 2022 14:01:59 +0100 | From | Peter Zijlstra <> | Subject | Re: [PATCH v2 3/6] perf/core: Don't pass task around when ctx sched in |
| |
On Tue, Mar 22, 2022 at 08:08:31PM +0800, Chengming Zhou wrote: > The current code pass task around for ctx_sched_in(), only > to get perf_cgroup of the task, then update the timestamp > of it and its ancestors and set them to active. > > But we can use cpuctx->cgrp to get active perf_cgroup and > its ancestors since cpuctx->cgrp has been set before > ctx_sched_in(). > > This patch remove the task argument in ctx_sched_in() > and cleanup related code. > > Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com>
Yeah, this looks reasonable I suppose...
| |