lkml.org 
[lkml]   [2022]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: linux-next: build warnings after merge of the tip tree
    On Mon, Mar 21, 2022 at 01:55:49PM +0100, Peter Zijlstra wrote:

    > > [ Note I was already getting these:
    > > arch/x86/crypto/chacha-x86_64.o: warning: objtool: chacha_2block_xor_avx512vl() falls through to next function chacha_8block_xor_avx512vl()
    > > arch/x86/crypto/chacha-x86_64.o: warning: objtool: chacha_4block_xor_avx512vl() falls through to next function chacha_8block_xor_avx512vl()
    > > arch/x86/crypto/poly1305-x86_64.o: warning: objtool: poly1305_blocks_avx() falls through to next function poly1305_blocks_x86_64()
    > > arch/x86/crypto/poly1305-x86_64.o: warning: objtool: poly1305_emit_avx() falls through to next function poly1305_emit_x86_64()
    > > arch/x86/crypto/poly1305-x86_64.o: warning: objtool: poly1305_blocks_avx2() falls through to next function poly1305_blocks_x86_64()
    >
    > Yes, those are somewhere on the todo list, lemme bump them.

    So the chacha one seems relatively simple, see below.

    ---
    diff --git a/arch/x86/crypto/chacha-avx512vl-x86_64.S b/arch/x86/crypto/chacha-avx512vl-x86_64.S
    index 946f74dd6fba..259383e1ad44 100644
    --- a/arch/x86/crypto/chacha-avx512vl-x86_64.S
    +++ b/arch/x86/crypto/chacha-avx512vl-x86_64.S
    @@ -172,7 +172,7 @@ SYM_FUNC_START(chacha_2block_xor_avx512vl)
    # xor remaining bytes from partial register into output
    mov %rcx,%rax
    and $0xf,%rcx
    - jz .Ldone8
    + jz .Ldone2
    mov %rax,%r9
    and $~0xf,%r9

    @@ -438,7 +438,7 @@ SYM_FUNC_START(chacha_4block_xor_avx512vl)
    # xor remaining bytes from partial register into output
    mov %rcx,%rax
    and $0xf,%rcx
    - jz .Ldone8
    + jz .Ldone4
    mov %rax,%r9
    and $~0xf,%r9

    \
     
     \ /
      Last update: 2022-03-22 11:48    [W:4.384 / U:0.316 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site