Messages in this thread | | | Date | Tue, 22 Mar 2022 09:40:00 +0100 | From | Krzysztof Kozlowski <> | Subject | Re: [PATCH v2 3/3] ARM: dts: aspeed: add reset properties into MDIO nodes |
| |
On 22/03/2022 03:32, Dylan Hung wrote: >> -----Original Message----- >> From: Krzysztof Kozlowski [mailto:krzk@kernel.org] >> Sent: 2022年3月21日 11:53 PM >> To: Dylan Hung <dylan_hung@aspeedtech.com>; robh+dt@kernel.org; >> joel@jms.id.au; andrew@aj.id.au; andrew@lunn.ch; hkallweit1@gmail.com; >> linux@armlinux.org.uk; davem@davemloft.net; kuba@kernel.org; >> pabeni@redhat.com; p.zabel@pengutronix.de; devicetree@vger.kernel.org; >> linux-arm-kernel@lists.infradead.org; linux-aspeed@lists.ozlabs.org; >> linux-kernel@vger.kernel.org; netdev@vger.kernel.org >> Cc: BMC-SW <BMC-SW@aspeedtech.com>; stable@vger.kernel.org >> Subject: Re: [PATCH v2 3/3] ARM: dts: aspeed: add reset properties into MDIO >> nodes >> >> On 21/03/2022 10:56, Dylan Hung wrote: >>> Add reset control properties into MDIO nodes. The 4 MDIO controllers in >>> AST2600 SOC share one reset control bit SCU50[3]. >>> >>> Signed-off-by: Dylan Hung <dylan_hung@aspeedtech.com> >>> Cc: stable@vger.kernel.org >> >> Please describe the bug being fixed. See stable-kernel-rules. > > Thank you for your comment. > The reset deassertion of the MDIO device was usually done by the bootloader (u-boot). > However, one of our clients uses proprietary bootloader and doesn't deassert the MDIO > reset so failed to access the HW in kernel driver. The reset deassertion is missing in the > kernel driver since it was created, should I add a BugFix for the first commit of this driver? > Or would it be better if I remove " Cc: stable@vger.kernel.org"?
This rather looks like a missing feature, not a bug. Anyway any description must be in commit message.
Best regards, Krzysztof
| |