Messages in this thread | | | Date | Tue, 22 Mar 2022 01:34:11 -0700 | From | Christoph Hellwig <> | Subject | Re: [PATCH v5 1/6] mm: rmap: fix cache flush on THP pages |
| |
On Fri, Mar 18, 2022 at 03:45:24PM +0800, Muchun Song wrote: > The flush_cache_page() only remove a PAGE_SIZE sized range from the cache. > However, it does not cover the full pages in a THP except a head page. > Replace it with flush_cache_range() to fix this issue. At least, no > problems were found due to this. Maybe because the architectures that > have virtual indexed caches is less. > > Fixes: f27176cfc363 ("mm: convert page_mkclean_one() to use page_vma_mapped_walk()") > Signed-off-by: Muchun Song <songmuchun@bytedance.com> > Reviewed-by: Yang Shi <shy828301@gmail.com> > Reviewed-by: Dan Williams <dan.j.williams@intel.com>
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
| |