lkml.org 
[lkml]   [2022]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v11 2/7] MIPS: Loongson64: dts: introduce ls3A4000 evaluation board
    From

    On 2022/3/23 10:29, Jiaxun Yang wrote:
    >
    >
    > 在 2022/3/23 1:53, Sui Jingfeng 写道:
    >> Hi, Jiaxun
    >>
    >> Build all dts into vmlinuz will make the vmlinuz bigger and bigger.
    >> How does the kernel get the dtb is another big issue, either from
    >> built-in
    >> dtb or pass from the firmware(pmon and uefi etc). This should be
    >> solved with another patch carefully. Providing board specific dts
    >> helps to code review, it helps reviewers understand that there are
    >> variant boards and have to be express with different OF graph.
    > Hi,
    >
    > I insist my taste on those code. If the only intention is to demonstrate
    > the usage of the driver then please just leave them in dt document
    > or commit message.
    >
    >>
    >> Now, there are about 6 dts under arch/mips/boot/dts/loongson/,
    >> Suppose loongson have 1000+ different board, do you want built all
    >> of them into vmlinuz?
    > Note that we are supporting all those boards on "platform" bias. Which
    > means if they share similar design then they will use the same DTS.
    > If we have a new design then unfortunately our kernel binary must grow.
    >
    > For those who intended to build a size-optimized kernel they will be
    > able to disable unused DTS in Kconfig.
    >
    > If you want to blame somebody for the problem then please don't
    > blame us. We tried very hard to fit all those stuff into kernel's model
    > of devices. You should blame those who did the initial design of
    > Loongson's boot interface that failed to introduce a proper way
    > to describe the platform.
    >
    >>
    >> Besides, ls7a1000 and ls2k1000 lack a i2c driver, gpio driver,
    >> pwm driver, clk driver, can you pay more attention to salve those
    >> problems, please ?
    > Are you trying to make a TODO list for your colleague :-)
    >
    > We , community developers, don't owe you anything. So please
    > don't expect anything from us. I lost access to most Loongson
    > devices since I'm currently study abroad, but I'm determined to
    > keep platform code in a good shape. That's my duty as a maintainer.
    >
    > Thanks.
    > - Jiaxun

    Providing a few board specific dts doesn't hurt anybody.

    Can we leave the problem(passing correct dts to the kernel) untouched and

    solve it in the feature with a another patch, ok?

    \
     
     \ /
      Last update: 2022-03-23 04:09    [W:4.047 / U:0.208 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site