lkml.org 
[lkml]   [2022]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v11 2/9] dt-bindings: reset: Add bindings for SP7021 reset driver
Date
> > +examples:
> > + - |
> > + rstc: reset@9c000054 {
> > + compatible = "sunplus,sp7021-reset";
> > + #reset-cells = <1>;
> > + reg = <0x9c000054 0x28>;
>
> I asked you to put the reg after compatible in all DTS code and
> examples. If you do not agree with a comment, please respond. Ignoring
> it is not cooperative.
>

Your reply: https://lore.kernel.org/all/d3ac3e2f-71fd-b2b4-7c7e-bb43c681d14e@canonical.com/
> > + - |
> > +
> > + clkc: clock-controller@9c000000 {
> > + compatible = "sunplus,sp7021-clkc";
> > + #clock-cells = <1>;
> > + reg = <0x9c000000 0x280>;
>
> In DTS code, please put reg after compatible. In all your examples and
> DTS patches.
>
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>

I see your review-tag. So, I misunderstand your comments.
Did you means 'reg' must directly after the 'compatible', like this?
clkc: clock-controller@9c000000 {
#clock-cells = <1>;
compatible = "sunplus,sp7021-clkc";
reg = <0x9c000000 0x280>;
\
 
 \ /
  Last update: 2022-03-23 02:59    [W:0.079 / U:1.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site