lkml.org 
[lkml]   [2022]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] Bluetooth: mt7921s: Fix a wrong judgment in btmtksdio_get_codec_config_data()
Date
Hi Yu,

>Since ven_data is a double pointer, it should be *ven_data here.
>
>Fixes: f41b91fa1783 ("Bluetooth: mt7921s: Add .btmtk_get_codec_config_data")
>Signed-off-by: Yu Liao <liaoyu15@huawei.com>
>---
> drivers/bluetooth/btmtksdio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/bluetooth/btmtksdio.c b/drivers/bluetooth/btmtksdio.c
>index f3dc5881fff7..b6d77e04240c 100644
>--- a/drivers/bluetooth/btmtksdio.c
>+++ b/drivers/bluetooth/btmtksdio.c
>@@ -961,7 +961,7 @@ static int btmtksdio_get_codec_config_data(struct hci_dev *hdev,
> }
>
> *ven_data = kmalloc(sizeof(__u8), GFP_KERNEL);
>- if (!ven_data) {
>+ if (!*ven_data) {
> err = -ENOMEM;
> goto error;
> }

Thanks for fixing this.

Reviewed-by: Miles Chen <miles.chen@mediatek.com>

\
 
 \ /
  Last update: 2022-03-22 23:58    [W:0.033 / U:0.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site