Messages in this thread | | | Date | Tue, 22 Mar 2022 07:26:45 +0000 | From | Lee Jones <> | Subject | Re: [PATCH] mfd: Use platform_get_irq() to get the interrupt |
| |
On Wed, 09 Mar 2022, cgel.zte@gmail.com wrote:
> From: Minghao Chi (CGEL ZTE) <chi.minghao@zte.com.cn> > > It is not recommened to use platform_get_resource(pdev, IORESOURCE_IRQ) > for requesting IRQ's resources any more, as they can be not ready yet in > case of DT-booting. > > platform_get_irq() instead is a recommended way for getting IRQ even if > it was not retrieved earlier. > > It also makes code simpler because we're getting "int" value right away > and no conversion from resource to int is required. > > The print function dev_err() is redundant because platform_get_irq() > already prints an error. > > Reported-by: Zeal Robot <zealci@zte.com.cn> > Signed-off-by: Minghao Chi (CGEL ZTE) <chi.minghao@zte.com.cn> > --- > drivers/mfd/ab8500-core.c | 12 +++++------- > 1 file changed, 5 insertions(+), 7 deletions(-)
Applied, thanks.
-- Lee Jones [李琼斯] Principal Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
| |