Messages in this thread | | | From | Peter Gonda <> | Date | Mon, 21 Mar 2022 09:42:39 -0600 | Subject | Re: [PATCH] Add KVM_EXIT_SHUTDOWN metadata for SEV-ES |
| |
On Mon, Mar 21, 2022 at 9:27 AM Paolo Bonzini <pbonzini@redhat.com> wrote: > > On 3/21/22 16:02, Peter Gonda wrote: > > SEV-ES guests can request termination using the GHCB's MSR protocol. See > > AMD's GHCB spec section '4.1.13 Termination Request'. Currently when a > > guest does this the userspace VMM sees an KVM_EXIT_UNKNOWN (-EVINAL) > > return code from KVM_RUN. By adding a KVM_EXIT_SHUTDOWN_ENTRY to kvm_run > > struct the userspace VMM can clearly see the guest has requested a SEV-ES > > termination including the termination reason code set and reason code. > > > > Signed-off-by: Peter Gonda <pgonda@google.com> > > Cc: Borislav Petkov <bp@alien8.de> > > Cc: Tom Lendacky <thomas.lendacky@amd.com> > > Cc: Brijesh Singh <brijesh.singh@amd.com> > > Cc: Joerg Roedel <jroedel@suse.de> > > Cc: Marc Orr <marcorr@google.com> > > Cc: Sean Christopherson <seanjc@google.com> > > Cc: kvm@vger.kernel.org > > Cc: linux-kernel@vger.kernel.org > > Looks good, but it has to also add a capability.
Thanks for the quick review! Just so I understand. I should add KVM_CAP_SEV_TERM or something, then if that has been enabled do the new functionality, else keep the old functionality?
> > > + /* KVM_EXIT_SHUTDOWN_ENTRY */ > > Just KVM_EXIT_SHUTDOWN. >
Will do.
| |