lkml.org 
[lkml]   [2022]   [Mar]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 5/6] ASoC: mediatek: mt8195: add machine support for max98390 and rt5682
On Mon, Mar 21, 2022 at 03:23:11PM +0800, Trevor Wu wrote:
> diff --git a/sound/soc/mediatek/mt8195/mt8195-mt6359.c b/sound/soc/mediatek/mt8195/mt8195-mt6359.c
[...]
> #define RT1011_SPEAKER_AMP_PRESENT BIT(0)
> #define RT1019_SPEAKER_AMP_PRESENT BIT(1)
> +#define MAX98390_SPEAKER_AMP_PRESENT BIT(2)
> +
> +#define MAX98390_CODEC_DAI "max98390-aif1"
> +#define MAX98390_DEV0_NAME "max98390.2-0038" /* right */
> +#define MAX98390_DEV1_NAME "max98390.2-0039" /* left */
>
> #define RT1011_CODEC_DAI "rt1011-aif"
> #define RT1011_DEV0_NAME "rt1011.2-0038"

The quirk bit order: RT1011, RT1019, and MAX98390. To be neat, move
MAX98390_CODEC_DAI, MAX98390_DEV0_NAME, and MAX98390_DEV1_NAME after
RT1019_DEV0_NAME to maintain the order.

> +static int mt8195_max98390_init(struct snd_soc_pcm_runtime *rtd)
[...]
> +
> + ret = snd_soc_dapm_add_routes(&card->dapm, mt8195_max98390_routes,
> + ARRAY_SIZE(mt8195_max98390_routes));
> +
> + if (ret)

Remove the extra blank line.

\
 
 \ /
  Last update: 2022-03-21 16:18    [W:1.195 / U:1.524 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site