Messages in this thread | | | Date | Mon, 21 Mar 2022 16:54:35 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH] ocfs2: fix check if list iterator did find an element |
| |
On Mon, Mar 21, 2022 at 02:34:34PM +0100, Jakob Koschel wrote: > >> @@ -556,11 +556,11 @@ static void *lockres_seq_start(struct seq_file *m, loff_t *pos) > >> } > >> } > >> > >> - list_for_each_entry(res, track_list, tracking) { > >> - if (&res->tracking == &dlm->tracking_list) > >> - res = NULL; > >> - else > >> - dlm_lockres_get(res); > >> + list_for_each_entry(iter, track_list, tracking) { > >> + if (&iter->tracking != &dlm->tracking_list) {
This is an open coded version of:
if (!list_entry_is_head(iter, &dlm->tracking_list, tracking)) {
Ideally someone would come through with enough confidence to just delete it but the second best option is to just make it readable...
regards, dan carpenter
> >> + dlm_lockres_get(iter); > >> + res = iter; > >> + } > >> break; > >> }
| |