Messages in this thread | | | From | <> | Subject | Re: [PATCH v2 8/8] mtd: spi-nor: spansion: Rework spi_nor_cypress_octal_dtr_enable() | Date | Mon, 21 Mar 2022 13:19:52 +0000 |
| |
On 3/21/22 14:34, Pratyush Yadav wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On 28/02/22 01:17PM, Tudor Ambarus wrote: >> Introduce template operation to remove code duplication. >> Split spi_nor_cypress_octal_dtr_enable() in >> spi_nor_cypress_octal_dtr_ena() spi_nor_cypress_octal_dtr_dis() as it no >> longer made sense to try to keep everything alltogether: too many >> "if (enable)" throughout the code, which made the code difficult to read. >> >> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com> > > Reviewed-by: Pratyush Yadav <p.yadav@ti.com> > > Will send my tested-by separately once I get a chance to test this. >
Thank you!
| |