lkml.org 
[lkml]   [2022]   [Mar]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v7 1/2] dt-bindings: watchdog: Add watchdog yaml file for Sunplus SP7021
Date
Dear Krzysztof
Thanks for your review.

> -----Original Message-----
> From: Krzysztof Kozlowski [mailto:krzk@kernel.org]
> Sent: Monday, March 21, 2022 7:10 PM
> To: xt.hu[胡先韬] <xt.hu@cqplus1.com>
> Cc: wim@linux-watchdog.org; p.zabel@pengutronix.de; linux-kernel@vger.kernel.org;
> linux-watchdog@vger.kernel.org; linux@roeck-us.net; robh+dt@kernel.org; devicetree@vger.kernel.org;
> Wells Lu 呂芳騰 <wells.lu@sunplus.com>; qinjian[覃健] <qinjian@cqplus1.com>; Rob Herring
> <robh@kernel.org>
> Subject: Re: [PATCH v7 1/2] dt-bindings: watchdog: Add watchdog yaml file for Sunplus SP7021
>
> On Fri, Mar 04, 2022 at 04:12:08PM +0800, Xiantao Hu wrote:
> > This adds the documentation for the devicetree bindings of the Sunplus
> > SP7021 watchdog driver, found from SP7021 SoCs and newer.
> >
> > Reviewed-by: Rob Herring <robh@kernel.org>
> > Signed-off-by: Xiantao Hu <xt.hu@cqplus1.com>
> > ---
> > .../bindings/watchdog/sunplus,sp7021-wdt.yaml | 47 +++++++++++++++++++
> > MAINTAINERS | 6 +++
> > 2 files changed, 53 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/watchdog/sunplus,sp7021-wdt.yaml
>
> Please use scripts/get_maintainer.pl on recent kernel (newest mainline or
> recent linux-next) to get the list of people to CC.
>

I will do it in the next patch.

> >
> > diff --git a/Documentation/devicetree/bindings/watchdog/sunplus,sp7021-wdt.yaml
> b/Documentation/devicetree/bindings/watchdog/sunplus,sp7021-wdt.yaml
> > new file mode 100644
> > index 000000000..9a9bfe150
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/watchdog/sunplus,sp7021-wdt.yaml
> > @@ -0,0 +1,47 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +# Copyright (C) Sunplus Co., Ltd. 2021
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/watchdog/sunplus,sp7021-wdt.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Sunplus SoCs Watchdog Device Tree Bindings
>
> s/Device Tree Bindings//
>

I will drop the string "Device Tree Bindings".

> > +
> > +maintainers:
> > + - XianTao Hu <xt.hu@cqplus1.com>
> > +
> > +allOf:
> > + - $ref: watchdog.yaml#
> > +
> > +properties:
> > + compatible:
> > + const: sunplus,sp7021-wdt
> > +
> > + reg:
> > + items:
> > + - description: watchdog registers regions
> > + - description: miscellaneous control registers regions
> > +
> > + clocks:
> > + maxItems: 1
> > +
> > + resets:
> > + maxItems: 1
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - clocks
> > + - resets
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + watchdog: watchdog@9c000630 {
> > + compatible = "sunplus,sp7021-wdt";
> > + reg = <0x9c000630 0x08>, <0x9C000274 0x04>;
>
> lowercase hex (Second reg)
>

I just realized the driver don't use second reg anymore. I will drop it and
modify the description of reg.

> Can be fixed while applying, so in such case:
> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
>

I got it.

Best regards,
Xian-tao
> Best regards,
> Krzysztof
\
 
 \ /
  Last update: 2022-03-21 13:21    [W:0.938 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site