lkml.org 
[lkml]   [2022]   [Mar]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 5.10-rt] printk: fix suppressed message print when reboot/panic
John Ogness <john.ogness@linutronix.de> writes:

> On 2022-03-21, Schspa Shi <schspa@gmail.com> wrote:
>> Update printk_seq for suppressed message.
>>
>> Affects 5.9-rt and 5.10-rt
>>
>> When message is suppressed, printk_seq should be updated, otherwise
>> this message will be printed when reboot. This problem was introduced
>> in commit 3edc0c85d154 ("printk: Rebase on top of new ring buffer").
>>
>> Signed-off-by: Schspa Shi <schspa@gmail.com>
>
> Reviewed-by: John Ogness <john.ogness@linutronix.de>
>
> Nice catch. Thanks.
>
> 5.15-rt also has this issue, although the fix is slightly different. For
> 5.15-rt, writing to con->printk_seq (via latched_seq_write()) requires
> the console locked. Would you like to post a patch for 5.15-rt as well,
> or would you like me to do it?
>

I have upload a new patch for 5.15-rt, please review it too.
Message-Id: <20220321111501.68241-1-schspa@gmail.com>

> 5.16 and beyond does not have this issue.
>
> John Ogness

BRs

Schspa Shi

\
 
 \ /
  Last update: 2022-03-21 12:58    [W:0.060 / U:1.000 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site