lkml.org 
[lkml]   [2022]   [Mar]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject答复: [PATCH] try: synclink cs: Use bitwise i nstead of arithmetic operator for flags
Date
Hi, sir

Ok, thank you for your reminder.
________________________________________
发件人: Jiri Slaby <jirislaby@kernel.org>
发送时间: 2022年3月21日 14:03:09
收件人: 白浩文; arnd@arndb.de; gregkh@linuxfoundation.org; dsterba@suse.com; elder@linaro.org; jcmvbkbc@gmail.com
抄送: johan@kernel.org; linux-kernel@vger.kernel.org
主题: Re: [PATCH] try: synclink_cs: Use bitwise instead of arithmetic operator for flags

Hi,

the $SUBJ says:

"try: synclink_cs: ..."

but you actually meant "tty:".

On 21. 03. 22, 4:04, Haowen Bai wrote:
> This silences the following coccinelle warning:
> drivers/s390/char/tape_34xx.c:360:38-39: WARNING: sum of probable bitmasks, consider |
>
> we will try to make code cleaner
>
> Signed-off-by: Haowen Bai <baihaowen@meizu.com>
> ---
> drivers/char/pcmcia/synclink_cs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/pcmcia/synclink_cs.c b/drivers/char/pcmcia/synclink_cs.c
> index 78baba5..e6f2186 100644
> --- a/drivers/char/pcmcia/synclink_cs.c
> +++ b/drivers/char/pcmcia/synclink_cs.c
> @@ -922,7 +922,7 @@ static void rx_ready_async(MGSLPC_INFO *info, int tcd)
> // BIT7:parity error
> // BIT6:framing error
>
> - if (status & (BIT7 + BIT6)) {
> + if (status & (BIT7 | BIT6)) {
> if (status & BIT7)
> icount->parity++;
> else


--
js
suse labs
\
 
 \ /
  Last update: 2022-03-21 07:13    [W:0.362 / U:0.268 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site