Messages in this thread | | | Date | Mon, 21 Mar 2022 18:38:18 +0700 | Subject | Re: [RFC PATCH v1 2/6] tools/nolibc: Make the entry point not weak for clang | From | Ammar Faizi <> |
| |
On 3/21/22 2:16 AM, Willy Tarreau wrote: > Hi Ammar, > > I've had a look at this one. > > On Sun, Mar 20, 2022 at 04:37:46PM +0700, Ammar Faizi wrote: >> Budilig with clang yields the following error: > ^^^^^^^ > BTW please fix the typo in the final commit message. > >> @@ -183,7 +183,9 @@ struct sys_stat_struct { >> >> /* startup code */ >> asm(".section .text\n" >> +#if !defined(__clang__) >> ".weak _start\n" >> +#endif >> ".global _start\n" >> "_start:\n" > > So it seems that I was wrong and that .weak is an alternate for .global > and not a complement. As such, instead of adding all these #if, please > simply remove all .global.
Will fix this in the next version.
-- Ammar Faizi
| |