lkml.org 
[lkml]   [2022]   [Mar]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/1] xen/blkfront: fix comment for need_copy
From
On 21.03.22 11:05, Roger Pau Monné wrote:
> On Thu, Mar 17, 2022 at 03:09:30PM -0700, Dongli Zhang wrote:
>> The 'need_copy' is set when rq_data_dir(req) returns WRITE, in order to
>> copy the written data to persistent page.
>>
>> ".need_copy = rq_data_dir(req) && info->feature_persistent,"
>
> I would also add:
>
> Fixes: c004a6fe0c40 ('block/xen-blkfront: Make it running on 64KB page granularity')

Hmm, a "Fixes:" tag for a change in a comment?

This might generate additional work e.g. for downstreams (we at SUSE have
scripts checking "Fixes:" tags and require such changes to be applied to
kernels having the fixed patch applied).

That said I'd prefer not having a "Fixes:" tag for such changes, but maybe
this is just due to the fact that it would be me having to apply this
patch to the SUSE kernels...


Juergen
[unhandled content-type:application/pgp-keys][unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2022-03-21 11:27    [W:0.518 / U:0.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site