Messages in this thread | | | Date | Mon, 21 Mar 2022 11:14:56 +0530 | Subject | Re: [PATCH v1 2/4] arm64: dts: qcom: sc7280: Add 'piglin' to the crd-r3 compatible strings | From | Rajendra Nayak <> |
| |
On 3/17/2022 5:58 AM, Matthias Kaehlcke wrote: > With newer bootloader versions the crd-r3 (aka CRD 1.0 and 2.0) is > identified as a 'piglin' board (like the IDP2 board), instead of 'hoglin' > Add the compatible strings 'google,piglin-rev{3,4}'. The hoglin entries > are kept to make sure the board keeps booting with older bootloader > versions.
The older bootloaders really look for the google,hoglin-rev3/google,hoglin-rev4 compatibles or just google,hoglin? If its just google,hoglin, won;t it pick the crd-rev5+ dtb now?
> > The compatible string 'google,piglin' (without revision information) is > still used by the IDP2 board, which is not expected to evolve further. > > Signed-off-by: Matthias Kaehlcke <mka@chromium.org> > --- > > arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts b/arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts > index 7a028b9248c3..344338ad8a01 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts > +++ b/arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts > @@ -12,7 +12,10 @@ > > / { > model = "Qualcomm Technologies, Inc. sc7280 CRD platform (rev3 - 4)"; > - compatible = "qcom,sc7280-crd", "google,hoglin-rev3", "google,hoglin-rev4", "qcom,sc7280"; > + compatible = "qcom,sc7280-crd", > + "google,hoglin-rev3", "google,hoglin-rev4", > + "google,piglin-rev3", "google,piglin-rev4", > + "qcom,sc7280"; > > aliases { > serial0 = &uart5;
| |