Messages in this thread | | | Date | Mon, 21 Mar 2022 09:39:26 +0100 | From | Paul Kocialkowski <> | Subject | Re: [PATCH resend] media: i2c: ov5648: fix wrong pointer passed to IS_ERR() and PTR_ERR() |
| |
Hi Yang,
On Sat 19 Mar 22, 11:58, Yang Yingliang wrote: > IS_ERR() and PTR_ERR() use wrong pointer, it should be > sensor->dovdd, fix it.
Nice catch, thank-you!
Reviewed-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Cheers,
Paul
> Fixes: e43ccb0a045f ("media: i2c: Add support for the OV5648 image sensor") > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> > --- > drivers/media/i2c/ov5648.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/i2c/ov5648.c b/drivers/media/i2c/ov5648.c > index 930ff6897044..dfcd33e9ee13 100644 > --- a/drivers/media/i2c/ov5648.c > +++ b/drivers/media/i2c/ov5648.c > @@ -2498,9 +2498,9 @@ static int ov5648_probe(struct i2c_client *client) > > /* DOVDD: digital I/O */ > sensor->dovdd = devm_regulator_get(dev, "dovdd"); > - if (IS_ERR(sensor->dvdd)) { > + if (IS_ERR(sensor->dovdd)) { > dev_err(dev, "cannot get DOVDD (digital I/O) regulator\n"); > - ret = PTR_ERR(sensor->dvdd); > + ret = PTR_ERR(sensor->dovdd); > goto error_endpoint; > } > > -- > 2.25.1 >
-- Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com [unhandled content-type:application/pgp-signature] | |