lkml.org 
[lkml]   [2022]   [Mar]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [f2fs-dev] [PATCH] f2fs: introduce data read/write showing path info
On 03/21, Eric Biggers wrote:
> On Mon, Mar 21, 2022 at 03:33:15PM -0700, Jaegeuk Kim wrote:
> > This was used in Android for a long time. Let's upstream it.
> >
>
> You still need to explain why this is useful.
>
> > +static inline char *f2fs_get_pathname(char *buf, int len, struct inode *inode)
> > +{
> > + char *path;
> > + struct dentry *d;
> > +
> > + /*
> > + * d_obtain_alias() will either iput() if it locates an existing
> > + * dentry or transfer the reference to the new dentry created.
> > + * So get an extra reference here.
> > + */
> > + ihold(inode);
> > + d = d_obtain_alias(inode);
>
> Why does this use d_obtain_alias() to get a dentry instead of just using the
> dentry of the open file?

:( I shouldn't copy the code from aosp simply.

>
> - Eric

\
 
 \ /
  Last update: 2022-03-22 01:20    [W:0.135 / U:0.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site