lkml.org 
[lkml]   [2022]   [Mar]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: r8188eu: remove local BIT macro
This version is better, thanks!

Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>

What the GCC devs should have done is run their checker on real code and
silence the common false positives. There are a few ways to do this.
You could make ~ a special case. They already ignore truncated sign
extension so they could equally well ignore truncation when all it's a
32 bits which are all set to 1. Probably the best answer is to do both.

Sure, you might miss some bugs that way, but anyone relying on GCC to
find *all* their bugs is a moron.

regards,
dan carpenter

\
 
 \ /
  Last update: 2022-03-21 09:18    [W:0.121 / U:0.212 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site