Messages in this thread | | | From | Linus Torvalds <> | Date | Mon, 21 Mar 2022 10:05:55 -0700 | Subject | Re: [PATCH v2] gpiolib: acpi: use correct format characters |
| |
On Mon, Mar 21, 2022 at 3:09 AM Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > > Would you sign off on this? I will then replace the original patch > with your version.
Sure. Note that I (intentionally) do bogus indentation of my inline patches, because that thing wasn't actually _tested_. It's obvious enough and should fix the issue, but I just wanted to point that out.
With that said, it's _so_ obviously correct (famous last words) that I'll happily add my sign-off to it:
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
and I suspect the explanations in the email could probably be used as much of a commit message.
> And for the record I have a follow up patch to clearly show that pin > is always unsigned, induced by this discussion.
Yeah, that sounds like a good idea - for a compiler it was obvious due to the load from a 'u16' array, but a human would actually have to go and check what that pin_table[] array was to see that "yup, that can't be negative in 'int'".
Linus
| |