Messages in this thread | | | Date | Wed, 2 Mar 2022 17:45:20 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH v1 1/1] KVM: s390: Don't cast parameter in bit operations |
| |
On Wed, Feb 23, 2022 at 06:44:20PM +0200, Andy Shevchenko wrote: > While in this particular case it would not be a (critical) issue, > the pattern itself is bad and error prone in case somebody blindly > copies to their code. > > Don't cast parameter to unsigned long pointer in the bit operations. > Instead copy to a local variable on stack of a proper type and use.
After looking into other similar cases I may conclude they - need to be fixed - out of scope of this change
Hence, can this fix be applied?
-- With Best Regards, Andy Shevchenko
| |