Messages in this thread | | | Date | Wed, 2 Mar 2022 08:06:16 -0500 | From | "Michael S. Tsirkin" <> | Subject | Re: [PATCH 3/3] wireguard: device: clear keys on VM fork |
| |
On Wed, Mar 02, 2022 at 12:44:45PM +0100, Jason A. Donenfeld wrote: > Hi Michael, > > On Wed, Mar 2, 2022 at 9:36 AM Michael S. Tsirkin <mst@redhat.com> wrote: > > Catastrophic cryptographic failure sounds bad :( > > So in another thread we discussed that there's a race with this > > approach, and we don't know how big it is. Question is how expensive > > it would be to fix it properly checking for fork after every use of > > key+nonce and before transmitting it. I did a quick microbenchmark > > and it did not seem too bad - care posting some numbers? > > I followed up in that thread, which is a larger one, so it might be > easiest to keep discussion there. My response to you here is the same > as it was over there. :) > > https://lore.kernel.org/lkml/CAHmME9pf-bjnZuweoLqoFEmPy1OK7ogEgGEAva1T8uVTufhCuw@mail.gmail.com/ > > Jason
Okay. The reason to respond here was since this is the user of the interface. Maybe unite the patchsets?
Thanks,
-- MST
| |