Messages in this thread | | | From | Alexei Starovoitov <> | Date | Wed, 2 Mar 2022 20:00:26 -0800 | Subject | Re: [PATCH bpf-next v1 8/9] bpf: Introduce cgroup iter |
| |
On Wed, Mar 2, 2022 at 7:03 PM Kumar Kartikeya Dwivedi <memxor@gmail.com> wrote: > > > > I think current approach is also not safe if cgroup_id gets reused, right? I.e. > it only does cgroup_get_from_id in seq_start, not at attach time, so it may not > be the same cgroup when calling read(2). kernfs is using idr_alloc_cyclic, so it > is less likely to occur, but since it wraps around to find a free ID it might > not be theoretical.
cgroupid is 64-bit.
| |